Skip to content

fix(Logger): disable channels instead of destroying the map on shutdo…#5325

Merged
matejk merged 3 commits intomainfrom
5324-logger-use-after-fee
Apr 21, 2026
Merged

fix(Logger): disable channels instead of destroying the map on shutdo…#5325
matejk merged 3 commits intomainfrom
5324-logger-use-after-fee

Conversation

@aleks-f
Copy link
Copy Markdown
Member

@aleks-f aleks-f commented Apr 19, 2026

…wn #5324

aleks-f and others added 3 commits April 21, 2026 08:23
Reflect the post-#5324 behavior: channels are detached and released
while Logger instances are kept alive, so cached Logger references
remain valid. Document the intended one-shot, pre-exit usage.
Regression test for the use-after-free fix: caches a Logger reference
before Logger::shutdown(), then logs through it after shutdown and
verifies the reference is still valid and logging is a safe no-op.
@matejk matejk force-pushed the 5324-logger-use-after-fee branch from a4d9678 to e309162 Compare April 21, 2026 06:24
@matejk matejk merged commit 28d3a81 into main Apr 21, 2026
39 of 51 checks passed
@matejk matejk deleted the 5324-logger-use-after-fee branch April 21, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logger::shutdown() use-after-free

2 participants